Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow collaborators to view repo owned by private org #6965

Merged
merged 2 commits into from
May 16, 2019
Merged

Allow collaborators to view repo owned by private org #6965

merged 2 commits into from
May 16, 2019

Conversation

mrsdizzie
Copy link
Member

Handle case where an organization is private but a user who is not a member of the organization has been added as a collaborator of a repo within that org

Fixes #6962

@mrsdizzie
Allow collaborators to view repo owned private org
85f20f3 
Handle case where an orginization is private but a user who is not a
member of the orgninization has been added as a collaborator of a repo
within that org

Fixes go-gitea#6962
@mrsdizzie mrsdizzie changed the title Allow collaborators to view repo owned private org Allow collaborators to view repo owned by private org if listed as collaborator May 16, 2019
@mrsdizzie mrsdizzie changed the title Allow collaborators to view repo owned by private org if listed as collaborator Allow collaborators to view repo owned by private org May 16, 2019
@codecov-io
Copy link

codecov-io commented May 16, 2019 •
edited
Loading

Codecov Report

Merging #6965 into master will increase coverage by <.01%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6965      +/-   ##
==========================================
+ Coverage   41.47%   41.47%   +<.01%     
==========================================
  Files         441      441              
  Lines       59662    59666       +4     
==========================================
+ Hits        24746    24749       +3     
  Misses      31695    31695              
- Partials     3221     3222       +1
Impacted Files Coverage Δ
models/repo_permission.go 73.77% <62.5%> (+0.47%) ⬆️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
models/repo_list.go 72.08% <0%> (-1.02%) ⬇️
models/gpg_key.go 55.83% <0%> (-0.84%) ⬇️
routers/repo/view.go 43.03% <0%> (+1.01%) ⬆️
modules/log/colors_router.go 87.5% <0%> (+4.16%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9dcd09...c24063b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 16, 2019
@lafriks lafriks added this to the 1.9.0 milestone May 16, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 16, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 16, 2019
@techknowlogick techknowlogick merged commit 68a83cc into go-gitea:master May 16, 2019
mrsdizzie added a commit to mrsdizzie/gitea that referenced this pull request May 16, 2019
@mrsdizzie
Allow collaborators to view repo owned private org (go-gitea#6965)
6590c3e 
Handle case where an orginization is private but a user who is not a
member of the orgninization has been added as a collaborator of a repo
within that org

Fixes go-gitea#6962
@mrsdizzie mrsdizzie mentioned this pull request May 16, 2019
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 16, 2019
techknowlogick pushed a commit that referenced this pull request May 16, 2019
@mrsdizzie @techknowlogick
Allow collaborators to view repo owned by private org (#6965) (#6968)
2198396 
* Allow collaborators to view repo owned private org (#6965)

Handle case where an orginization is private but a user who is not a
member of the orgninization has been added as a collaborator of a repo
within that org

Fixes #6962

* Match release/v1.8 fixtures
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@mrsdizzie @jeffliu27
Allow collaborators to view repo owned private org (go-gitea#6965)
8b29d13 
Handle case where an orginization is private but a user who is not a
member of the orgninization has been added as a collaborator of a repo
within that org

Fixes go-gitea#6962
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Collaborators in repositories in private organisations cannot access repository
7 participants
@mrsdizzie @codecov-io @lunny @zeripath @techknowlogick @lafriks @GiteaBot